netdev - Re: [PATCH net,v2] vrf: check accept_source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3ae7363-f1a1-b290-8797-7aff6d514d65@gmail.com>
Date:   Sun, 31 Mar 2019 18:06:23 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, ssuryaextr@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net,v2] vrf: check accept_source_route on the original
 netdevice

On 3/31/19 2:57 PM, David Miller wrote:
> From: Stephen Suryaputra <ssuryaextr@...il.com>
> Date: Wed, 27 Mar 2019 15:58:48 -0400
> 
>> Configuration check to accept source route IP options should be made on
>> the incoming netdevice when the skb->dev is an l3mdev master. The route
>> lookup for the source route next hop also needs the incoming netdev.
>>
>> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> 
> David, please review this.
> 
> Thanks.
> 

now that my heart rate is back to normal following the Auburn game ...

The change can be much simpler by passing the device down the stack from
where it is saved before the skb->dev switch.