netdev - Re: [PATCH bpf-next 7/7] selftests/bpf: add few verifier scale tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <319e168a-6571-9a70-336a-6ecf8b61f040@iogearbox.net>
Date:   Mon, 1 Apr 2019 16:17:55 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     jakub.kicinski@...ronome.com, jannh@...gle.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: add few verifier scale tests

On 03/30/2019 01:16 AM, Alexei Starovoitov wrote:
> Add 3 basic tests that stress verifier scalability.
> 
> test_verif_scale1.c calls non-inlined jhash() function 90 times on
> different position in the packet.
> This test simulates network packet parsing.
> jhash function is ~140 instructions and main program is ~1200 insns.
> 
> test_verif_scale2.c force inlines jhash() function 90 times.
> This program is ~15k instructions long.
> 
> test_verif_scale3.c calls non-inlined jhash() function 90 times on
> But this time jhash has to process 32-bytes from the packet
> instead of 14-bytes in tests 1 and 2.
> jhash function is ~230 insns and main program is ~1200 insns.
> 
> $ test_progs -s
> can be used to see verifier stats.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Do you also have some test cases with actual 1M insns resp. such that hit
the new complexity limit to check timing / resources it consumes? I think
these would be good to have as well as part of selftests.