lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <fe3f5b79-9725-a858-c641-b50623f1000b@iogearbox.net> Date: Mon, 1 Apr 2019 18:09:09 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Alexei Starovoitov <alexei.starovoitov@...il.com>, Andrey Ignatov <rdna@...com> Cc: Network Development <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Kernel Team <kernel-team@...com> Subject: Re: [PATCH bpf-next 0/2] bpf: Support variable offset stack access from helpers On 03/29/2019 08:10 PM, Alexei Starovoitov wrote: > On Thu, Mar 28, 2019 at 6:02 PM Andrey Ignatov <rdna@...com> wrote: >> >> The patch set adds support for stack access with variable offset from helpers. >> >> Patch 1 is the main patch in the set and provides more details. >> Patch 2 adds selftests for new functionality. > > Applied. Thanks Hmm, I think this series needs more work unfortunately. The selftests are only checking root-only programs, which is way to little. For !root we do the spectre masking for map and stack ALU, and that hasn't been adapted here, so it will generate a wrong masking for runtime since it doesn't take variable part into account. Andrey, please take a look.
Powered by blists - more mailing lists