netdev - Re: [PATCH net] net: tls: prevent false connection termination with offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190329.133941.1073614751791804879.davem@davemloft.net>
Date:   Fri, 29 Mar 2019 13:39:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        borisp@...lanox.com, davejwatson@...com, vakul.garg@....com,
        simon.horman@...ronome.com
Subject: Re: [PATCH net] net: tls: prevent false connection termination
 with offload

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu, 28 Mar 2019 14:54:43 -0700

> Only decrypt_internal() performs zero copy on rx, all paths
> which don't hit decrypt_internal() must set zc to false,
> otherwise tls_sw_recvmsg() may return 0 causing the application
> to believe that that connection got closed.
> 
> Currently this happens with device offload when new record
> is first read from.
> 
> Fixes: d069b780e367 ("tls: Fix tls_device receive")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Applied, thanks Jakub.