netdev - Re: [PATCH] ipv4 ping: Fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190401.180006.1452941870052618794.davem@davemloft.net>
Date:   Mon, 01 Apr 2019 18:00:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andi@...stfloor.org
Cc:     netdev@...r.kernel.org, ak@...ux.intel.com
Subject: Re: [PATCH] ipv4 ping: Fix __init* attributes

From: Andi Kleen <andi@...stfloor.org>
Date: Fri, 29 Mar 2019 17:46:00 -0700

> From: Andi Kleen <ak@...ux.intel.com>
> 
> ping_v4_net_ops references init functions, so needs to be __initdata.
> ping_proc_exit is then referenced from __initdata, so also needs
> to be __init.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

How can you spin up new network namespaces properly if you mark
this thing __init?

What __init functions does it even reference?  It just creates and
destroys procfs files.

This patch doesn't seem correct, I'm not applying it.