netdev - Re: [PATCH net-next] openvswitch: use after free in __ovs_ct_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG1aQhLqiPKaMbvZD1kjsU4TM=j0yhSF3jRmy2szuCpdTKpfTg@mail.gmail.com>
Date:   Tue, 2 Apr 2019 10:05:24 -0700
From:   Yi-Hung Wei <yihung.wei@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Pravin B Shelar <pshelar@....org>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        ovs dev <dev@...nvswitch.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] openvswitch: use after free in __ovs_ct_free_action()

On Mon, Apr 1, 2019 at 11:53 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> We free "ct_info->ct" and then use it on the next line when we pass it
> to nf_ct_destroy_timeout().  This patch swaps the order to avoid the use
> after free.
>
> Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
Thanks for the fix.

Acked-by: Yi-Hung Wei <yihung.wei@...il.com>