netdev - Re: [PATCH net-next v2] macsec: add noinline tag to avoid a frame size warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190401.185223.618235417569364629.davem@davemloft.net>
Date:   Mon, 01 Apr 2019 18:52:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, sd@...asysnail.net
Subject: Re: [PATCH net-next v2] macsec: add noinline tag to avoid a frame
 size warning

From: Florian Westphal <fw@...len.de>
Date: Mon,  1 Apr 2019 22:59:09 +0200

> seen with debug config:
> drivers/net/macsec.c: In function 'dump_secy':
> drivers/net/macsec.c:2597: warning: the frame size of 2216 bytes is larger
> than 2048 bytes [-Wframe-larger-than=]
> 
> just mark it with noinline_for_stack, this is netlink dump code.
> 
> v2: use 'static noinline_for_stack int' consistently
> 
> Cc: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thank you.