netdev - Re: [PATCH mlx5-next 08/14] net/mlx5: Make mlx5_core messages independent from mdev->pdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <275478b86f42b2de5b49b20113b1a96a70b33c44.camel@mellanox.com>
Date:   Tue, 2 Apr 2019 19:43:37 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Leon Romanovsky <leonro@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Huy Nguyen <huyn@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Vu Pham <vuhuong@...lanox.com>,
        "saeed@...lanox.com" <saeed@...lanox.com>
Subject: Re: [PATCH mlx5-next 08/14] net/mlx5: Make mlx5_core messages
 independent from mdev->pdev

On Sat, 2019-03-30 at 08:08 +0000, Leon Romanovsky wrote:
> On Fri, Mar 29, 2019 at 03:37:58PM -0700, Saeed Mahameed wrote:
> > From: Huy Nguyen <huyn@...lanox.com>
> > 
> > Detach mlx5_core mdev messages from pci device mdev->pdev messages
> > and
> > provide a better report/debug of different mlx5 device types.
> > 
> > This patch does not change any functionality.
> > 
> > Signed-off-by: Huy Nguyen <huyn@...lanox.com>
> > Signed-off-by: Vu Pham <vuhuong@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> > ---
> >  .../ethernet/mellanox/mlx5/core/mlx5_core.h   | 19 +++++++++----
> > ------
> >  1 file changed, 9 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > index 7b331674622c..052e81974c3b 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > @@ -48,12 +48,12 @@
> >  extern uint mlx5_core_debug_mask;
> > 
> >  #define mlx5_core_dbg(__dev, format, ...)				
> > \
> > -	dev_dbg(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,		
> > \
> > +	pr_debug("%s:%s:%d:(pid %d): " format, (__dev)-
> > >priv.name,      \
> >  		 __func__, __LINE__, current->pid,			\
> 
> I see that we printed PID even before this patch, but unfortunately
> it
> is wrong and doesn't handle correctly kernel contexts.
> 
> If you are changing those debug prints, it will be nicer to use
> CONFIG_PRINTK_CALLER instead like we are doing for the timestamps.
> 
> https://marc.info/?l=linux-rdma&m=155289145403897&w=2
> 

Cool, i will defer this to a future work, since it is going to be a
bigger change.

> Thanks