netdev - Re: [PATCH net-next] net: sched: don't set tunnel for decap action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190402.132049.72774598864366010.davem@davemloft.net>
Date:   Tue, 02 Apr 2019 13:20:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: don't set tunnel for decap action

From: Vlad Buslov <vladbu@...lanox.com>
Date: Mon,  1 Apr 2019 14:16:59 +0300

> Action tunnel_key doesn't have a metadata/tunnel for release(decap) action.
> Drivers do not dereference entry->tunnel pointer for that action type, so
> this behavior doesn't result in a crash at the moment. However, this needs
> to be corrected as a preparation for updating hardware offloads API to not
> rely on rtnl lock, for which flow_action code will copy the tunnel data to
> temporary buffer to prevent concurrent action overwrite from
> invalidating/freeing it.
> 
> Fixes: 3a7b68617de7 ("cls_api: add translator to flow_action representation")
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied, thanks Vlad.