netdev - Re: [PATCH net-next 16/17] Documentation: networking: dsa: Add details about NXP SJA1105 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Apr 2019 23:24:22 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     f.fainelli@...il.com, vivien.didelot@...il.com,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linus.walleij@...aro.org,
        georg.waibel@...sor-technik.de
Subject: Re: [PATCH net-next 16/17] Documentation: networking: dsa: Add
 details about NXP SJA1105 driver

> +The switches do not support switch tagging in hardware. But they do support
> +customizing the TPID by which VLAN traffic is identified as such. The switch
> +driver is leveraging CONFIG_NET_DSA_TAG_8021Q by requesting that special VLANs
> +(with a custom TPID of ETH_P_EDSA instead of ETH_P_8021Q)

Hi Vladimir

Reusing ETH_P_EDSA is possibility going to case problems in tcpdump.
It has code which looks for this Ethertype and uses it to call the
Marvell EDSA header decoder code. This is not going to work for your
switch, where you have a normal VLAN header.

I wounder if we should allocate a new EtherType for this application
of VLANs?

   Andrew