netdev - Re: [PATCHv2 net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 01 Apr 2019 18:11:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCHv2 net-next] net: use rcu_dereference_protected to fetch
 sk_dst_cache in sk_destruct

From: Xin Long <lucien.xin@...il.com>
Date: Sun, 31 Mar 2019 17:03:02 +0800

> As Eric noticed, in .sk_destruct, sk->sk_dst_cache update is prevented, and
> no barrier is needed for this. So change to use rcu_dereference_protected()
> instead of rcu_dereference_check() to fetch sk_dst_cache in there.
> 
> v1->v2:
>   - no change, repost after net-next is open.
> 
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks.