netdev - Re: [PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADmRdJcWLuV-69OxLJC4UC2VnUJo3yUaTDrjJ5NxnTxJw0Y+OA@mail.gmail.com>
Date:   Wed, 3 Apr 2019 08:16:23 -0500
From:   Steve Wise <larrystevenwise@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Leon Romanovsky <leon@...nel.org>, stephen@...workplumber.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

On Sun, Mar 31, 2019 at 9:06 PM David Ahern <dsahern@...il.com> wrote:
>
> On 3/26/19 1:18 PM, Steve Wise wrote:
> > This function sends the constructed netlink message and then
> > receives the response.
> >
> > Change rd_recv_msg() to display any error messages.
> >
> > Change 'rdma dev set' to use rd_sendrecv_msg().
> >
> > Signed-off-by: Steve Wise <larrystevenwise@...il.com>
> > ---
> >  rdma/dev.c   |  2 +-
> >  rdma/rdma.h  |  2 ++
> >  rdma/res.h   |  1 +
> >  rdma/utils.c | 18 ++++++++++++++++++
> >  4 files changed, 22 insertions(+), 1 deletion(-)
> >
> > diff --git a/rdma/dev.c b/rdma/dev.c
> > index 954e0015..33962520 100644
> > --- a/rdma/dev.c
> > +++ b/rdma/dev.c
> > @@ -268,7 +268,7 @@ static int dev_set_name(struct rd *rd)
> >       mnl_attr_put_u32(rd->nlh, RDMA_NLDEV_ATTR_DEV_INDEX, rd->dev_idx);
> >       mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, rd_argv(rd));
> >
> > -     return rd_send_msg(rd);
> > +     return rd_sendrecv_msg(rd, seq);
> >  }
> >
> >  static int dev_one_set(struct rd *rd)
> > diff --git a/rdma/rdma.h b/rdma/rdma.h
> > index 1022e9a2..6c7f7d15 100644
> > --- a/rdma/rdma.h
> > +++ b/rdma/rdma.h
> > @@ -68,6 +68,7 @@ struct rd {
> >       json_writer_t *jw;
> >       bool json_output;
> >       bool pretty_output;
> > +     bool suppress_errors;
> >       struct list_head filter_list;
> >  };
> >
>
> All of the suppress_errors seems like an unrelated change.
>

Hey David,

I just realized I replied only to you directly, so I'll reply again to everyone.

It is a bug fix that showed itself when I moved the error check to
rd_recv_msg(), which Leon recommended in the last review cycle.  The
bug doesn't manifest unless this series is applied, so the suppress
errors  fix is really only needed as part of this series.

Thanks,

Steve.