netdev - Re: [PATCH net-next 2/2] net: phy: realtek: remove setting callback get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ce042f8-855f-14ff-8edb-6d72e0d1a12a@gmail.com>
Date:   Wed, 3 Apr 2019 23:06:32 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove setting callback
 get_features and use phylib fallback

On 03.04.2019 22:55, Andrew Lunn wrote:
> On Wed, Apr 03, 2019 at 08:20:09PM +0200, Heiner Kallweit wrote:
>> Now that phylib uses genphy_read_abilities() as fallback, we don't have
>> to set callback get_features any longer.
> 
> Hi Heiner
> 
> I wonder how many PHY drivers we will break if we just remove
> .features everywhere?
> 
At least I have seen no C22 PHY yet that couldn't be handled by
genphy_read_abilities. Just for non-TP modes there might be an issue.
genphy_read_abilities only sets TP and MII, if a driver checks for
e.g. ETHTOOL_LINK_MODE_FIBRE_BIT we may have some work.

> Maybe we should create patches for the Marvell driver and the Broadcom
> drivers. I and Florian can test them.
> 
> 	 Andrew
> 
Heiner