netdev - Re: [PATCH net-next v2 1/2] net: phy: allow a PHY driver to define neither features nor get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190403212534.GI4592@lunn.ch>
Date:   Wed, 3 Apr 2019 23:25:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/2] net: phy: allow a PHY driver to define
 neither features nor get_features

On Wed, Apr 03, 2019 at 11:14:33PM +0200, Heiner Kallweit wrote:
> Meanwhile we have generic functions for reading the abilities of
> Clause 22 / 45 PHY's. This allows to use them as fallback in case
> callback get_features isn't set. Benefit is the reduction of
> boilerplate code in PHY drivers.
> 
> v2:
> - adjust the comment in phy_driver_register to match the code
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew