netdev - Re: [PATCH v2 ipsec-next 00/11] xfrm: remove xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 10:31:35 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 ipsec-next 00/11] xfrm: remove xfrm_mode indirections

2019-03-29, 21:16:21 +0100, Florian Westphal wrote:
> This series removes all function pointers from the xfrm_mode struct.
> They are either replaced by direct calls or a static helper.
> 
> This reduces code size: even merging all xfrm{4,6}_,mode* modules
> into the core reduces total size, as the infrastructure to maintain
> dynamic (un)register can be removed.
> 
> There are more opportunities for indirection avoidance, e.g. in
> xfrm_type.  I plan to follow up once/if this series is accepted.
> 
> Tested with xfrm tunnel mode via netns with esp/aead.
> 
> I'd like thank Benedict Wong for running Android unit tests
> and taking the time to bisect a tunnel mode breakage added by
> v1 of this patch set.
> 
> I've addressed the comments/feedback from Sabrina and Eyal.
> The kbuild robot reported build breakage in patch #8 is fixed
> as well.
> 
> I've not addressed the sparse warning reported by the
> kbuild robot -- those warnings are in code not touched
> by this patch set.
> 
> Florian Westphal (11):
>       xfrm: place af number into xfrm_mode struct
>       xfrm: prefer family stored in xfrm_mode struct
>       xfrm: remove input indirection from xfrm_mode
>       xfrm: remove output indirection from xfrm_mode
>       xfrm: remove xmit indirection from xfrm_mode
>       xfrm: remove gso_segment indirection from xfrm_mode
>       xfrm: remove input2 indirection from xfrm_mode
>       xfrm: remove output2 indirection from xfrm_mode
>       xfrm: remove afinfo pointer from xfrm_mode
>       xfrm: make xfrm modes builtin
>       xfrm: store xfrm_mode directly, not its address

Series:
Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina