netdev - Re: [PATCH net-next 01/12] net: hns3: check 1000M half for hns3_ethtool_ops.set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd51c598-c4df-f10f-91ca-2f5081bead68@cogentembedded.com>
Date:   Wed, 3 Apr 2019 12:12:22 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Huazhong Tan <tanhuazhong@...wei.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, Peng Li <lipeng321@...wei.com>
Subject: Re: [PATCH net-next 01/12] net: hns3: check 1000M half for
 hns3_ethtool_ops.set_link_ksettings

Hello!

On 03.04.2019 6:07, Huazhong Tan wrote:

> From: Peng Li <lipeng321@...wei.com>
> 
> Hip08 SOC does not support 1000M half, this patch adds 1000M half
> check for hns3_ethtool_ops.set_link_ksettings, so the user can not
> set 1000M half by ethtool.
> 
> Signed-off-by: Peng Li <lipeng321@...wei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> ---
>   drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 359d473..0c05807 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -648,6 +648,10 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
>   static int hns3_set_link_ksettings(struct net_device *netdev,
>   				   const struct ethtool_link_ksettings *cmd)
>   {
> +	/* Chip don't support this mode. */

    Doesn't.

[...]

MBR, Sergei