netdev - Re: [PATCH bpf 1/2] ixgbe: fix AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45aa47d7-dea3-e554-2623-bcabf64f8a87@iogearbox.net>
Date:   Thu, 4 Apr 2019 02:13:19 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     William Tu <u9012063@...il.com>, netdev@...r.kernel.org,
        bjorn.topel@...el.com, ast@...nel.org, magnus.karlsson@...el.com,
        jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count

[ +Jeff ]

Given these two are contained to ixgbe, I presume Jeff wants to pick
these up instead via his tree?

On 04/03/2019 11:57 PM, William Tu wrote:
> The tx bytecount is done twice.  When running
> './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
> The avg packet size is 120 instead of 60. So remove the
> extra one.
> 
> Signed-off-by: William Tu <u9012063@...il.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
> index bfe95ce0bd7f..71b8474a9b4c 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
> @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector,
>  			xsk_frames++;
>  
>  		tx_bi->xdpf = NULL;
> -		total_bytes += tx_bi->bytecount;
>  
>  		tx_bi++;
>  		tx_desc++;
>