netdev - Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 15:59:17 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Neal Cardwell <ncardwell@...gle.com>,
        "Tilmans, Olivier (Nokia - BE/Antwerp)" 
        <olivier.tilmans@...ia-bell-labs.com>
Cc:     "De Schepper, Koen (Nokia - BE/Antwerp)" 
        <koen.de_schepper@...ia-bell-labs.com>,
        Bob Briscoe <research@...briscoe.net>,
        Lawrence Brakmo <brakmo@...com>,
        Florian Westphal <fw@...len.de>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Yuchung Cheng <ycheng@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Shewmaker <agshew@...il.com>,
        Glenn Judd <glenn.judd@...ganstanley.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

On 04/04/2019 03:55 PM, Neal Cardwell wrote:
> On Thu, Apr 4, 2019 at 9:48 AM Neal Cardwell <ncardwell@...gle.com> wrote:
>> On Thu, Apr 4, 2019 at 8:24 AM Tilmans, Olivier (Nokia - BE/Antwerp)
>> <olivier.tilmans@...ia-bell-labs.com> wrote:
>>>
>>> From: Koen De Schepper <koen.de_schepper@...ia-bell-labs.com>
>>>
>>> RFC8257 §3.5 explicitly states that "A DCTCP sender MUST react to
>>> loss episodes in the same way as conventional TCP".
>> ...
>>> This patch replace the clamping of alpha by setting ssthresh to
>>> half of cwnd for both fast retransmissions and RTOs, at most once
>>> per RTT. Consequently, the dctcp_clamp_alpha_on_loss module parameter
>>> has been removed.
>>
>> Acked-by: Neal Cardwell <ncardwell@...gle.com>
>>
>> Thanks!
> 
> FWIW, my vote is that this is an important bug fix that is appropriate
> for the net branch and -stable releases, rather than net-next.

Agree, my preference would be for -net tree as well. Thanks for the fix!

Acked-by: Daniel Borkmann <daniel@...earbox.net>