netdev - Re: [PATCH bpf-next] kbuild: add ability to generate BTF type info for vmlinux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 21:40:42 -0300
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>, andrii.nakryiko@...il.com,
        bpf@...r.kernel.org, netdev@...r.kernel.org, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Alexei Starovoitov <ast@...com>, Yonghong Song <yhs@...com>,
        Martin KaFai Lau <kafai@...com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH bpf-next] kbuild: add ability to generate BTF type info
 for vmlinux

Em Wed, Apr 03, 2019 at 11:12:58AM +0200, Jiri Olsa escreveu:
> On Wed, Apr 03, 2019 at 11:04:28AM +0200, Daniel Borkmann wrote:
> > On 04/03/2019 10:46 AM, Jiri Olsa wrote:
> > > On Tue, Apr 02, 2019 at 09:49:50AM -0700, andrii.nakryiko@...il.com wrote:
> > >> From: Andrii Nakryiko <andriin@...com>
> > >>
> > >> This patch adds new config option to trigger generation of BTF type
> > >> information from DWARF debuginfo for vmlinux and kernel modules through
> > >> pahole, which in turn relies on libbpf for btf_dedup() algorithm.
> > > I'm using the latest pahole from git tree:

> > >   https://github.com/acmel/dwarves.git

I've updated this oen as well, but the canonical one is at:

git://git.kernel.org/pub/scm/devel/pahole/pahole.git

See the fix below.

> > > and getting pahole crash:

> > >   LD      vmlinux
> > >   BTF     vmlinux
> > > die__process_inline_expansion: DW_TAG_label (0xa) @ <0x3eef8> not handled!
> > > scripts/link-vmlinux.sh: line 96: 31222 Segmentation fault      (core dumped) LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${1}
> > > make[1]: *** [/home/jolsa/linux/Makefile:1025: vmlinux] Error 139
> > > make: *** [Makefile:170: sub-make] Error 2

> > > is there some other source/dependency I'm missing?

> > Yesterday night, I've tested with [0] but seems to have the same HEAD as
> > the github repo you pointed out. Seems the above is coming from pahole's
> > __die__process_tag() bailing out with default for DW_TAG_label?

> > On my side worked fine:
 
> hum, I also had to change the version of pahole in the patch to allow
> version v1.12, because both latest pahole sources are on version 1.12,
> did u have to do that? looks like there's v1.13 somewhere ;-)

So, I've reproduced the problem and fixed it, please pull my latest
master branch from git://git.kernel.org/pub/scm/devel/pahole/pahole.git,
please do the hack to make it expect v1.12, I'll try and relase v1.13
soon, if nothing else pops up soon.

Thanks for the report!

- Arnaldo