netdev - Re: [PATCH net] net: thunderx: fix NULL pointer dereference in nicvf_open/nicvf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 04 Apr 2019 10:45:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, mcroce@...hat.com, vlomovtsev@...vell.com
Subject: Re: [PATCH net] net: thunderx: fix NULL pointer dereference in
 nicvf_open/nicvf_stop

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Thu,  4 Apr 2019 12:16:27 +0200

> When a bpf program is uploaded, the driver computes the number of
> xdp tx queues resulting in the allocation of additional qsets.
> Starting from commit '2ecbe4f4a027 ("net: thunderx: replace global
> nicvf_rx_mode_wq work queue for all VFs to private for each of them")'
> the driver runs link state polling for each VF resulting in the
> following NULL pointer dereference:
 ...
> Fix it by checking nicvf_rx_mode_wq pointer in nicvf_open and nicvf_stop
> 
> Fixes: 2ecbe4f4a027 ("net: thunderx: replace global nicvf_rx_mode_wq work queue for all VFs to private for each of them")
> Fixes: 2c632ad8bc74 ("net: thunderx: move link state polling function to VF")
> Reported-by: Matteo Croce <mcroce@...hat.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied and queued up for -stable.