[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 03 Apr 2019 21:48:06 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: hkallweit1@...il.com
Cc: andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: fix autoneg mismatch case in
genphy_read_status
From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 2 Apr 2019 20:43:30 +0200
> The original patch didn't consider the case that autoneg process
> finishes successfully but both link partners have no mode in common.
> In this case there's no link, nevertheless we may be interested in
> what the link partner advertised.
>
> Like phydev->link we set phydev->autoneg_complete in
> genphy_update_link() and use the stored value in genphy_read_status().
> This way we don't have to read register BMSR again.
>
> Fixes: b6163f194c69 ("net: phy: improve genphy_read_status")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
Applied.
Powered by blists - more mailing lists