netdev - Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 Apr 2019 08:20:08 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     linux-rockchip@...ts.infradead.org, briannorris@...omium.org,
        mka@...omium.org, ryandcase@...omium.org, heiko@...ech.de,
        "David S. Miller" <davem@...emloft.net>,
        Ganapathi Bhat <gbhat@...vell.com>,
        linux-wireless@...r.kernel.org,
        Amitkumar Karwar <amitkarwar@...il.com>,
        linux-kernel@...r.kernel.org,
        Nishant Sarmukadam <nishants@...vell.com>,
        netdev@...r.kernel.org, Xinming Hu <huxinming820@...il.com>
Subject: Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards

Douglas Anderson <dianders@...omium.org> writes:

> The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
> adapter status variables") had a fairly straightforward bug in it.  It
> contained this bit of diff:
>
>  - if (!adapter->is_suspended) {
>  + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
>
> As you can see the patch missed the "!" when converting to the atomic
> bitops.  This meant that the resume hasn't done anything at all since
> that commit landed and suspend/resume for mwifiex SDIO cards has been
> totally broken.
>
> After fixing this mwifiex suspend/resume appears to work again, at
> least with the simple testing I've done.
>
> Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

I'm planning to queue this for 5.1.

-- 
Kalle Valo