netdev - Re: [PATCH bpf-next] samples/bpf: fix build with new clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3cd94b55-acb7-b4d3-cedd-55b11fd7bd53@iogearbox.net>
Date:   Fri, 5 Apr 2019 17:03:27 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH bpf-next] samples/bpf: fix build with new clang

On 04/04/2019 11:37 PM, Alexei Starovoitov wrote:
> clang started to error on invalid asm clobber usage in x86 headers
> and many bpf program samples failed to build with the message:
> 
>   CLANG-bpf  /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.o
> In file included from /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.c:14:
> In file included from ../include/linux/in.h:23:
> In file included from ../include/uapi/linux/in.h:24:
> In file included from ../include/linux/socket.h:8:
> In file included from ../include/linux/uio.h:14:
> In file included from ../include/crypto/hash.h:16:
> In file included from ../include/linux/crypto.h:26:
> In file included from ../include/linux/uaccess.h:5:
> In file included from ../include/linux/sched.h:15:
> In file included from ../include/linux/sem.h:5:
> In file included from ../include/uapi/linux/sem.h:5:
> In file included from ../include/linux/ipc.h:9:
> In file included from ../include/linux/refcount.h:72:
> ../arch/x86/include/asm/refcount.h:72:36: error: asm-specifier for input or output variable conflicts with asm clobber list
>                                          r->refs.counter, e, "er", i, "cx");
>                                                                       ^
> ../arch/x86/include/asm/refcount.h:86:27: error: asm-specifier for input or output variable conflicts with asm clobber list
>                                          r->refs.counter, e, "cx");
>                                                              ^
> 2 errors generated.
> 
> Override volatile() to workaround the problem.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Applied, thanks!