netdev - Re: [iproute2] ip: support for xfrm interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190405210317.dtvseosbu3tobula@AntonyAntony.local>
Date:   Fri, 5 Apr 2019 23:03:18 +0200
From:   Antony Antony <antony@...nome.org>
To:     Matt Ellison <matt@...oyo.io>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute2] ip: support for xfrm interfaces


Tested-by: Antony Antony <antony@...nome.org>

On Fri, Apr 05, 2019 at 03:46:02PM -0400, Matt Ellison wrote:
> I recently submitted v3 of the patch, please take a look there.

great. I am testing v3 now.

One comment. It seems to accept -ve value for if_id and quietly set to 0
may be throw an error for -ve values? or take it as u32?
in my opinion setting to 0 is confusing

sudo ./ip/ip link add ipsec0 type xfrm dev enp0s5 if_id -10
build@d28:~/git/iproute2 (master)$ ./ip/ip -d link show ipsec0
33: ipsec0@...0s5: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/none 00:1c:42:55:d6:ab brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
    xfrm if_id 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 
65536 gso_max_segs 65535

> > Question: is it easy to add "if_id" to "ip link show" output?
> 
> Yes, it should show up under the detailed output for the interface (-d).

great thanks.

sudo ./ip/ip link add ipsec0 type xfrm dev enp0s5 if_id 0xAB

./ip/ip -d link show ipsec0
29: ipsec0@...0s5: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/none 00:1c:42:55:d6:ab brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
    xfrm if_id 0xab addrgenmode eui64 numtxqueues 1 numrxqueues 1 
gso_max_size 65536 gso_max_segs 65535

thanks,
-antony