netdev - Re: [PATCH net v6] failover: allow name change on IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1bbdc3b-7083-fa66-b27b-73c28303aa51@oracle.com>
Date:   Fri, 5 Apr 2019 15:13:52 -0700
From:   si-wei liu <si-wei.liu@...cle.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     mst@...hat.com, sridhar.samudrala@...el.com, davem@...emloft.net,
        kubakici@...pl, alexander.duyck@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        liran.alon@...cle.com, boris.ostrovsky@...cle.com,
        vijay.balakrishna@...cle.com
Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave
 interfaces



On 4/5/2019 2:47 PM, Stephen Hemminger wrote:
> On Wed,  3 Apr 2019 00:52:47 -0400
> Si-Wei Liu <si-wei.liu@...cle.com> wrote:
>
>>   
>> +	if (unlikely(dev->flags & IFF_UP)) {
>> +		struct netdev_notifier_change_info change_info = {
>> +			.info.dev = dev,
>> +		};
>> +
>> +		call_netdevice_notifiers_info(NETDEV_CHANGE,
>> +					      &change_info.info);
>> +	}
> This notifier is not really necessary, there already is a CHANGENAME
> that gets sent.
>
> NETDEV_CHANGE is used in other cases to mean that the state (flags)
> have changed.
Honestly I myself did not find NETDEV_CHANGE useful, but it was your 
call... Anyway, I can remove this notifier and get the patch back to 
close to v2 except for flag name.

https://patchwork.ozlabs.org/patch/1052633/

But what left open is should we really need to notify userspace of link 
state change around rename, which is what Michael suggested, but turns 
out too involved.

Let me know if you intend to remove it or leave it as-is.

-Siwei