netdev - Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e5b047e-8ee1-ee53-cd46-3be70f0d618f@gmail.com>
Date:   Fri, 5 Apr 2019 02:23:41 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Lawrence Brakmo <brakmo@...com>,
        "Tilmans, Olivier (Nokia - BE/Antwerp)" 
        <olivier.tilmans@...ia-bell-labs.com>,
        David Miller <davem@...emloft.net>
Cc:     "De Schepper, Koen (Nokia - BE/Antwerp)" 
        <koen.de_schepper@...ia-bell-labs.com>,
        "research@...briscoe.net" <research@...briscoe.net>,
        "fw@...len.de" <fw@...len.de>,
        "borkmann@...earbox.net" <borkmann@...earbox.net>,
        "ycheng@...gle.com" <ycheng@...gle.com>,
        "ncardwell@...gle.com" <ncardwell@...gle.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "agshew@...il.com" <agshew@...il.com>,
        "glenn.judd@...ganstanley.com" <glenn.judd@...ganstanley.com>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses



On 04/04/2019 11:55 AM, Lawrence Brakmo wrote:
> 
> The module parameter, even if enabled by default, would have been
> preferable since it would support environments where this feature
> turned out to be sub-optimal.

Module parameters are awful, just add a sysctl if you need.

Bonus : per netns thing, meaning writing tests (say with packetdrill) is easier,
since you can launch dozens of them in parallel, each one in a different netns.