lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 6 Apr 2019 13:24:26 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: megous@...ous.com, linux-sunxi@...glegroups.com, Maxime Ripard <maxime.ripard@...tlin.com>, Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org> Cc: Icenowy Zheng <icenowy@...c.io>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Mark Rutland <mark.rutland@....com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Arend van Spriel <arend.vanspriel@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, Wright Feng <wright.feng@...ress.com>, Kalle Valo <kvalo@...eaurora.org>, Naveen Gupta <naveen.gupta@...ress.com>, dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-wireless@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com, linux-gpio@...r.kernel.org Subject: Re: [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one Hello! On 06.04.2019 2:45, megous@...ous.com wrote: > From: Icenowy Zheng <icenowy@...c.io> > > The PHY selection bit also exists on SoCs without an internal PHY; if > it's set to 1 (internal PHY) then the MAC will not make use of any PHY. > > This problem appears when adapting for H6, which has no real internal > PHY (the "internal PHY" on H6 is not on-die, but on a co-packaged AC200 > chip, via RMII interface at GPIO bank A), but the PHY selection bit is > set. > > Force the PHY selection bit to 0 when no external PHY to select this > problem. "Select this problem" sound weird... > Signed-off-by: Icenowy Zheng <icenowy@...c.io> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index e3e3dc44b33b..bd340e77b2ea 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -908,6 +908,11 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) > * address. No need to mask it again. > */ > reg |= 1 << H3_EPHY_ADDR_SHIFT; > + } else { > + /* For SoCs without internal PHY the PHY selection bit should be > + * set to 0 (external PHY). > + */ > + reg &= ~(H3_EPHY_SELECT); No () should be needed here, add () around the macro body if still needed. [...] MBR, Sergei
Powered by blists - more mailing lists