lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 06 Apr 2019 15:04:48 -0700 (PDT) From: David Miller <davem@...emloft.net> To: dan.carpenter@...cle.com Cc: sameo@...ux.intel.com, christophe.ricard@...il.com, linux-wireless@...r.kernel.org, kernel-janitors@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 2/2 net] nfc: nci: Potential off by one in ->pipes[] array From: Dan Carpenter <dan.carpenter@...cle.com> Date: Wed, 3 Apr 2019 10:13:51 +0300 > This is similar to commit e285d5bfb7e9 ("NFC: Fix the number of pipes") > where we changed NFC_HCI_MAX_PIPES from 127 to 128. > > As the comment next to the define explains, the pipe identifier is 7 > bits long. The highest possible pipe is 127, but the number of possible > pipes is 128. As the code is now, then there is potential for an > out of bounds array access: > > net/nfc/nci/hci.c:297 nci_hci_cmd_received() warn: array off by one? > 'ndev->hci_dev->pipes[pipe]' '0-127 == 127' > > Fixes: 11f54f228643 ("NFC: nci: Add HCI over NCI protocol support") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Applied.
Powered by blists - more mailing lists