netdev - Re: [PATCH][next] net: hns: fix unsigned comparison to less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190406.182935.1539123668739096067.davem@davemloft.net>
Date:   Sat, 06 Apr 2019 18:29:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        liuyonglong@...wei.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: hns: fix unsigned comparison to less than
 zero

From: Colin King <colin.king@...onical.com>
Date: Fri,  5 Apr 2019 14:59:16 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently mskid is unsigned and hence comparisons with negative
> error return values are always false. Fix this by making mskid an
> int.
> 
> Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem")
> Addresses-Coverity: ("Operands don't affect result")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.