netdev - Re: [PATCH bpf-next] libbpf: Ignore -Wformat-nonliteral warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190407061521.cbhmbt33wnf36dnu@ast-mbp.dhcp.thefacebook.com>
Date:   Sat, 6 Apr 2019 23:15:23 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrey Ignatov <rdna@...com>
Cc:     netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        kernel-team@...com
Subject: Re: [PATCH bpf-next] libbpf: Ignore -Wformat-nonliteral warning

On Sat, Apr 06, 2019 at 10:37:34PM -0700, Andrey Ignatov wrote:
> vsprintf() in __base_pr() uses nonliteral format string and it breaks
> compilation for those who provide corresponding extra CFLAGS, e.g.:
> https://github.com/libbpf/libbpf/issues/27
> 
> If libbpf is built with the flags from PR:
> 
>   libbpf.c:68:26: error: format string is not a string literal
>   [-Werror,-Wformat-nonliteral]
>           return vfprintf(stderr, format, args);
>                                   ^~~~~~
>   1 error generated.
> 
> Ignore this warning since the use case in libbpf.c is legit.
> 
> Signed-off-by: Andrey Ignatov <rdna@...com>

Applied, Thanks