netdev - Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190406.181428.1813237479044536410.davem@davemloft.net>
Date:   Sat, 06 Apr 2019 18:14:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, wangchen@...fujitsu.com, sbrivio@...hat.com
Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative
 overflow

From: Hangbin Liu <liuhangbin@...il.com>
Date: Thu,  4 Apr 2019 20:45:18 +0800

> Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti
> overflow"), we should not decrease promiscuity if it is already 0.
> 
> An example is after adding a team interface to bridge, the team interface
> will enter promisc mode. Then if we add a slave to team0, the slave will
> keep promisc off. If we remove team from bridge, both team0 and slave will
> decrease the promiscuity, which will cause a negative overflow on the slave.
> The team's issue will be fixed in a separate patch.
> 
> Reviewed-by: Stefano Brivio <sbrivio@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

These little hacks are endless.

I would rather see team and bridge and bonding appropriately keep the
promisc count adjusted as need when slaves are added/removed etc.

What is the point of the counter if it doesn't "count" properly?

I'm not applying this.

Because if I apply it, this just encourages more hackish workarounds
for the fundamental problem.