netdev - Re: [PATCH net-next] datagram: remove rendundant 'peeked' argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190408.095710.652342565205432754.davem@davemloft.net>
Date:   Mon, 08 Apr 2019 09:57:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net-next] datagram: remove rendundant 'peeked' argument

From: Paolo Abeni <pabeni@...hat.com>
Date: Mon,  8 Apr 2019 10:15:59 +0200

> After commit a297569fe00a ("net/udp: do not touch skb->peeked unless
> really needed") the 'peeked' argument of __skb_try_recv_datagram()
> and friends is always equal to !!'flags & MSG_PEEK'.
> 
> Since such argument is really a boolean info, and the callers have
> already 'flags & MSG_PEEK' handy, we can remove it and clean-up the
> code a bit.
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks Paolo.