netdev - Re: [PATCH v2 2/3] broadcom: tg3: fix use of SPEED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190408175225.GE15267@lunn.ch>
Date:   Mon, 8 Apr 2019 19:52:25 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Zhivich <mzhivich@...mai.com>
Cc:     davem@...emloft.net, siva.kallam@...adcom.com,
        prashant@...adcom.com, mchan@...adcom.com, shshaikh@...vell.com,
        manishc@...vell.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/3] broadcom: tg3: fix use of SPEED_UNKNOWN ethtool
 constant

On Mon, Apr 08, 2019 at 10:48:46AM -0400, Michael Zhivich wrote:
> tg3 driver uses u16 to store SPEED_UKNOWN ethtool constant,
> which is defined as -1, resulting in value truncation and
> thus incorrect test results against SPEED_UNKNOWN.
> 
> For example, the following test will print "False":
> 
> 	u16 speed = SPEED_UNKNOWN;
> 
> 	if (speed == SPEED_UNKNOWN)
> 	    printf("True");
> 	else
> 	    printf("False");
> 
> Change storage of speed to use u32 to avoid this issue.
> 
> Signed-off-by: Michael Zhivich <mzhivich@...mai.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew