netdev - Re: [PATCH v2 0/3] ethtool: fix use of SPEED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16F0FA8E-A44B-42BD-8B36-1B3886228D95@akamai.com>
Date:   Mon, 8 Apr 2019 18:40:38 +0000
From:   "Zhivich, Michael" <mzhivich@...mai.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "siva.kallam@...adcom.com" <siva.kallam@...adcom.com>,
        "prashant@...adcom.com" <prashant@...adcom.com>,
        "mchan@...adcom.com" <mchan@...adcom.com>,
        "shshaikh@...vell.com" <shshaikh@...vell.com>,
        "manishc@...vell.com" <manishc@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

On 4/8/19, 1:55 PM, "Andrew Lunn" <andrew@...n.ch> wrote:

>On Mon, Apr 08, 2019 at 10:48:44AM -0400, Michael Zhivich wrote:
>> This patch series addresses 2 related issues:
>> 
>> 1. ethtool_validate_speed() triggers a "signed-unsigned comparison"
>> warning due to type difference of SPEED_UNKNOWN constant (int)
>> and argument to ethtool_validate_speed (__u32).
>> 
>> 2. some drivers use u16 storage for SPEED_UNKNOWN constant, 
>> resulting in value truncation and thus failure to test against
>> SPEED_UNKNOWN correctly.
>> 
>> This revised series addresses several feedback comments:
>> - split up the patch in to series
>> - do not unnecessarily change drivers that use "int" storage
>>   for speed values
>
>Hi Michael
>
>Your v1 had some changes which changed plain int value speeds to using
>the SPEED_X macros. Those changes appear to of disappeared. You could
>submit them as well.
>
>       Thanks
>	Andrew

Hi Andrew,

I dropped those changes since they were purely cosmetic and not 
required for this patch series.  

I'll resubmit that set of changes as a separate patch.

Thanks,
~ Michael