netdev - Re: [PATCH net v3] net: vrf: Fix ping failed when vrf mtu is set to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190407.224947.1057169172447711389.davem@davemloft.net>
Date:   Sun, 07 Apr 2019 22:49:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsa@...ulusnetworks.com
Cc:     linmiaohe@...wei.com, shrijeet@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mingfangsen@...wei.com
Subject: Re: [PATCH net v3] net: vrf: Fix ping failed when vrf mtu is set
 to 0

From: David Ahern <dsa@...ulusnetworks.com>
Date: Sun, 7 Apr 2019 20:51:05 -0700

> On 4/7/19 7:04 PM, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@...wei.com>
>> 
>> When the mtu of a vrf device is set to 0, it would cause ping
>> failed. So I think we should limit vrf mtu in a reasonable range
>> to solve this problem. I set dev->min_mtu to IPV6_MIN_MTU, so it
>> will works for both ipv4 and ipv6. And if dev->max_mtu still be 0
>> can be confusing, so I set dev->max_mtu to ETH_MAX_MTU.
>> 
>> Here is the reproduce step:
 ...
>> Fixes: ad49bc6361ca2 ("net: vrf: remove MTU limits for vrf device")
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
> 
> Reviewed-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks.