netdev - Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190408192244.GH6051@lunn.ch>
Date:   Mon, 8 Apr 2019 21:22:44 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Zhivich <mzhivich@...mai.com>
Cc:     davem@...emloft.net, sgoutham@...ium.com, rric@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed
 and duplex

On Mon, Apr 08, 2019 at 03:00:46PM -0400, Michael Zhivich wrote:
> Use constants provided by ethtool.h for speed and duplex values
> instead of raw integer constants to increase code readability.
> 
> thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
> also provided by ethtool.h.
> 
> Signed-off-by: Michael Zhivich <mzhivich@...mai.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew