netdev - Re: [PATCH net-next 5/5] Revert: "net: sched: put back q.qlen into a single location"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1871d6ac-cb83-69a5-608c-d944fa93b315@gmail.com>
Date:   Mon, 8 Apr 2019 14:17:43 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Eric Dumazet <edumazet@...gle.com>,
        Ivan Vecera <ivecera@...hat.com>
Subject: Re: [PATCH net-next 5/5] Revert: "net: sched: put back q.qlen into a
 single location"



On 04/08/2019 09:35 AM, Paolo Abeni wrote:
> This revert commit 46b1c18f9deb ("net: sched: put back q.qlen
> into a single location").
> After the previous patch nobody accesses directly qlen for a child
> qdisc when such qdisc does per CPU stats accounting.
> In the control path nobody uses directly qlen since commit
> 677f1bc207c ("net: sched: introduce and use qdisc tree flush/purge
> helpers"), so we can remove the contented atomic ops from the
> datapath.
>

Have you tested HTB with a pfifo_fast on a throttled class ?

I do not see any changes in HTB in your patch series, so it is not
clear why your patch series is not adding back the issue.