netdev - RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Apr 2019 10:46:52 +0000
From:   <RaghuramChary.Jallipalli@...rochip.com>
To:     <Jisheng.Zhang@...aptics.com>, <marc.zyngier@....com>
CC:     <Woojung.Huh@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

> > Is this warning specific to any linux version?
> 
> In theory, no. I only tested 5.0, 4.20, both can reproduce this warning.
>
This makes me think that code is fine because it occurs in 4.20 and greater. Or maybe the problem is masked in older. I maybe wrong in assuming that. 
 
> 
> The warning comes from calling generic_handle_irq() in usb tasklet context.
> This is not correct.
> 
> Per my understanding, if there's chained irq, we could introduce extra
> irqdomain. E.g
> 
> GIC <--> another irqchip controller <--> HW device
> 
Correct, IRQ domain is generally used in chained irq controllers.
Yes, We need to check why irq domain is used in the current driver.

Thanks