netdev - RE: NAT performance regression caused by vlan GRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3c778121cf94e4386bfcaf56858433b@AcuMS.aculab.com>
Date:   Mon, 8 Apr 2019 13:31:33 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Rafał Miłecki' <zajec5@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        "Florian Westphal" <fw@...len.de>,
        Eric Dumazet <eric.dumazet@...il.com>
CC:     Stefano Brivio <sbrivio@...hat.com>,
        Sabrina Dubroca <sd@...asysnail.net>,
        David Ahern <dsahern@...il.com>, Felix Fietkau <nbd@....name>,
        "Jo-Philipp Wich" <jo@...n.io>,
        Koen Vandeputte <koen.vandeputte@...ntric.com>
Subject: RE: NAT performance regression caused by vlan GRO support

From: Rafal Milecki
> Sent: 07 April 2019 12:55
...
> If not, maybe w really need to think about some good & clever condition for
> disabling GRO by default on hw without checksum offloading.

Maybe GRO could assume the checksums are valid so the checksum
would only be verified when the packet is delivered locally.

If the packet is forwarded then, provided the same packet
boundaries are used, the original checksums (maybe modified
by NAT) can be used.

No idea how easy this might be :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)