netdev - Re: [PATCH bpf-next] libbpf: fix crash in XDP socket part with new larger BPF_LOG_BUF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5CED6A9-274F-491E-AF88-B05E745B0BD5@flugsvamp.com>
Date:   Tue, 09 Apr 2019 09:04:11 -0700
From:   "Jonathan Lemon" <jlemon@...gsvamp.com>
To:     "Magnus Karlsson" <magnus.karlsson@...el.com>
Cc:     bjorn.topel@...el.com, ast@...nel.org, daniel@...earbox.net,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] libbpf: fix crash in XDP socket part with new
 larger BPF_LOG_BUF_SIZE

On 9 Apr 2019, at 5:49, Magnus Karlsson wrote:

> In commit da11b417583e ("libbpf: teach libbpf about log_level bit 2"),
> the BPF_LOG_BUF_SIZE was increased to 16M. The XDP socket part of
> libbpf allocated the log_buf on the stack, but for the new 16M buffer
> size this is not going to work. Change the code to allocate the
> log_buf using malloc instead. If the allocation fails, we go ahead and
> load the program without a log buffer.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>

Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>