netdev - Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190409.135944.1516944884952068835.davem@davemloft.net>
Date:   Tue, 09 Apr 2019 13:59:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, richardcochran@...il.com,
        khilman@...libre.com, heiko@...ech.de,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic
 feature detection

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 7 Apr 2019 11:57:13 +0200

> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
> 
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

This appears to need to be done differently.

A question was asked as to why fast ethernet PHY identification from the
source is important, well I'd say it's important for someone working on
the PHY code to see how "all fast ethernet PHY drivers do or handle X"

:-)