netdev - Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871s2bzg4v.fsf@toke.dk>
Date:   Tue, 09 Apr 2019 11:23:28 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        BjörnTöpel <bjorn.topel@...il.com>,
        brouer@...hat.com
Subject: Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device

Jesper Dangaard Brouer <brouer@...hat.com> writes:

> On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
>> +void dev_map_put_default_map(struct net *net)
>> +{
>> +        mutex_lock(&dev_map_mtx);
>
> Looks like a white-space error...
>
>> +	if (atomic_dec_and_test(&net->xdp.default_map.use_cnt)) {
>> +		__dev_map_release_default_map(&net->xdp.default_map);
>> +	}
>> +        mutex_unlock(&dev_map_mtx);
>
> And here again.

Yeah, and there are more :/

Will fix, thanks!

-Toke