Date:   Wed, 10 Apr 2019 16:36:17 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     linux-kernel@...r.kernel.org
Cc:     Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        "David S . Miller" <davem@...emloft.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Christian Kellner <ckellner@...hat.com>,
        Mario.Limonciello@...l.com, Joe Perches <joe@...ches.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        netdev@...r.kernel.org
Subject: [PATCH v4 00/36] thunderbolt: Software connection manager improvements

Hi,

This is fourth iteration of the patch series improving software connection
manager capabilities to support:

  - PCIe tunnels for full daisy chain up to 6 devices
  - Display port tunneling
  - P2P networking

The series applies on top of thunderbolt.git/next.

Previous version of the patch series can be viewed here:

  v3: https://lkml.org/lkml/2019/3/28/310
  v2: https://lkml.org/lkml/2019/2/6/347
  v1: https://lkml.org/lkml/2019/1/29/924

Changes from v3:

  * Added tags from Lukas.

  * Fixed typo get_switch_by_route() -> get_switch_at_route().

  * In patch 12 drop check for port->sw->is_unplugged (done already in
    patch 4) and add check for -ENODEV instead.

  * Fixed tb_path_alloc() to make sure in_hopid matches the previous
    out_hopid in patch 19. Also updated kernel-docs accordingly.

  * Added missing \n termination in patch 34.

Changes from v2 (major):

  * Always set port->remote even in case of dual link connection.

  * Leave (DP, PCIe) tunnels up when the driver is unloaded. When loaded
    back, it discovers the existing tunnels and updated data structures
    accordingly. I noticed that the code in v2 did not support cases
    properly when you unplug something before the driver gets loaded back.
    This version tears down partial paths during discovery.

  * Do not automatically create PCIe tunnels. Instead we implement "user"
    security level in the software connection manager as well taking
    advantage of the existing sysfs interfaces. This allows user to disable
    PCIe tunneling completely or implement different white listing
    policies. Major distros include bolt system daemon that takes care of
    this.

  * When testing on two-port Falcon Ridge based system I realized
    that we always just pick the first available PCIe downstream adapter
    regardless of which Thunderbolt port you plug the device which is not
    consistent. To solve this we add mapping between host PCIe downstream
    adapter and the Thunderbolt port for Cactus Ridge and Falcon Ridge
    based systems.

  * Take domain lock in switch sysfs callbacks. This is needed because the
    software connection manager needs to walk over the topology during
    tunnel creation so switch_lock is not enough anymore.

Changes from v1:

  * Added ACK from David

  * Add constant (TMU_ACCESS_EN) for BIT(20) when TMU access is enabled. We
    keep it in cap.c close to the LR/ER workaround. Also we enable/disable
    only during capability walk. If it turns we need to have it enabled
    elsewhere we can move it to switch.c and enable just once during
    switch enumeration.

  * Use 0 to mean no cap_adap instead of negative value. This follows
    cap_phy.

  * Use correct PCI IDs (_BRIDGE) in the last patch where we start firmware
    on Titan Ridge. It wrongly used NHI PCI IDs in v1.

Mika Westerberg (36):
  net: thunderbolt: Unregister ThunderboltIP protocol handler when suspending
  thunderbolt: Remove unused work field in struct tb_switch
  thunderbolt: Drop duplicated get_switch_at_route()
  thunderbolt: Block reads and writes if switch is unplugged
  thunderbolt: Take domain lock in switch sysfs attribute callbacks
  thunderbolt: Do not allocate switch if depth is greater than 6
  thunderbolt: Enable TMU access when accessing port space on legacy devices
  thunderbolt: Add dummy read after port capability list walk on Light Ridge
  thunderbolt: Move LC specific functionality into a separate file
  thunderbolt: Configure lanes when switch is initialized
  thunderbolt: Set sleep bit when suspending switch
  thunderbolt: Properly disable path
  thunderbolt: Cache adapter specific capability offset into struct port
  thunderbolt: Rename tunnel_pci to tunnel
  thunderbolt: Generalize tunnel creation functionality
  thunderbolt: Add functions for allocating and releasing HopIDs
  thunderbolt: Assign remote for both ports in case of dual link
  thunderbolt: Add helper function to iterate from one port to another
  thunderbolt: Extend tunnel creation to more than 2 adjacent switches
  thunderbolt: Deactivate all paths before restarting them
  thunderbolt: Discover preboot PCIe paths the boot firmware established
  thunderbolt: Add support for full PCIe daisy chains
  thunderbolt: Scan only valid NULL adapter ports in hotplug
  thunderbolt: Generalize port finding routines to support all port types
  thunderbolt: Rework NFC credits handling
  thunderbolt: Add support for Display Port tunnels
  thunderbolt: Do not tear down tunnels when driver is unloaded
  thunderbolt: Run tb_xdp_handle_request() in system workqueue
  thunderbolt: Add XDomain UUID exchange support
  thunderbolt: Add support for DMA tunnels
  thunderbolt: Make tb_switch_alloc() return ERR_PTR()
  thunderbolt: Add support for XDomain connections
  thunderbolt: Make __TB_[SW|PORT]_PRINT take const parameters
  thunderbolt: Make rest of the logging to happen at debug level
  thunderbolt: Reword output of tb_dump_hop()
  thunderbolt: Start firmware on Titan Ridge Apple systems

 drivers/net/thunderbolt.c        |   3 +
 drivers/thunderbolt/Makefile     |   4 +-
 drivers/thunderbolt/cap.c        |  85 +++-
 drivers/thunderbolt/ctl.c        |   2 +-
 drivers/thunderbolt/icm.c        |  60 ++-
 drivers/thunderbolt/lc.c         | 179 ++++++++
 drivers/thunderbolt/nhi.c        |   3 +-
 drivers/thunderbolt/path.c       | 420 ++++++++++++++++---
 drivers/thunderbolt/switch.c     | 551 +++++++++++++++++++-----
 drivers/thunderbolt/tb.c         | 608 ++++++++++++++++++++-------
 drivers/thunderbolt/tb.h         | 225 ++++++++--
 drivers/thunderbolt/tb_msgs.h    |  11 +
 drivers/thunderbolt/tb_regs.h    |  50 ++-
 drivers/thunderbolt/tunnel.c     | 691 +++++++++++++++++++++++++++++++
 drivers/thunderbolt/tunnel.h     |  78 ++++
 drivers/thunderbolt/tunnel_pci.c | 226 ----------
 drivers/thunderbolt/tunnel_pci.h |  31 --
 drivers/thunderbolt/xdomain.c    | 147 ++++++-
 include/linux/thunderbolt.h      |   8 +
 19 files changed, 2720 insertions(+), 662 deletions(-)
 create mode 100644 drivers/thunderbolt/lc.c
 create mode 100644 drivers/thunderbolt/tunnel.c
 create mode 100644 drivers/thunderbolt/tunnel.h
 delete mode 100644 drivers/thunderbolt/tunnel_pci.c
 delete mode 100644 drivers/thunderbolt/tunnel_pci.h

-- 
2.20.1

Powered by blists - more mailing lists