netdev - Re: [RFC net-next 1/1] tdc.py: Introduce required plugins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0c266ba-8749-c8a6-738a-7fe905682398@6wind.com>
Date:   Wed, 10 Apr 2019 16:33:52 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Lucas Bates <lucasb@...atatu.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, mleitner@...hat.com, vladbu@...lanox.com,
        dcaratti@...hat.com, kernel@...atatu.com
Subject: Re: [RFC net-next 1/1] tdc.py: Introduce required plugins

Le 09/04/2019 à 23:44, Lucas Bates a écrit :
> Some of the testcases (for example, all of the fw tests) in tdc
> require activating the nsplugin. This RFC introduces a feature which
> tags one such test with the keyword "requires". Anyone running a test
> that requires nsplugin will now get a warning if they are missing
> the plugin.
> 
> After compiling the list of test cases to execute, tdc will
> gather all of the required plugins for that run, and validate
> that they have been enabled with a symlink in the plugins/
> directory. If required plugins are missing, tdc will create the
> symlink for the user and then terminate. (This is because plugin-
> specific options may exist and need to be parsed at startup)
I still don't understand the goal of this plugin. Why not simply include it in
the core code (like it was some times ago)?

> 
> Please provide feedback.  If this is amenable to all, I will proceed
> to submit for the rest.
After your patch, I got the following error:
$ ./tdc.py
Traceback (most recent call last):
  File "./tdc.py", line 740, in <module>
    main()
  File "./tdc.py", line 734, in main
    set_operation_mode(pm, args)
  File "./tdc.py", line 692, in set_operation_mode
    check_required_plugins(pm, alltests)
  File "./tdc.py", line 583, in check_required_plugins
    os.chown('plugins/{}'.format(fname), uid=int(os.getenv('SUDO_UID')),
TypeError: int() argument must be a string or a number, not 'NoneType'


Regards,
Nicolas