netdev - Re: [PATCH bpf-next v2] libbpf: fix crash in XDP socket part with new larger BPF_LOG_BUF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH3MdRXkQzN3srL1Bmkf18Tvb7Uk1M6XQFDog7eA-fPa38Cpog@mail.gmail.com>
Date:   Wed, 10 Apr 2019 10:29:49 -0700
From:   Y Song <ys114321@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...el.com>
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        netdev <netdev@...r.kernel.org>, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v2] libbpf: fix crash in XDP socket part with new
 larger BPF_LOG_BUF_SIZE

On Tue, Apr 9, 2019 at 11:55 PM Magnus Karlsson
<magnus.karlsson@...el.com> wrote:
>
> In commit da11b417583e ("libbpf: teach libbpf about log_level bit 2"),
> the BPF_LOG_BUF_SIZE was increased to 16M. The XDP socket part of
> libbpf allocated the log_buf on the stack, but for the new 16M buffer
> size this is not going to work. Change the code so it uses a 16K buffer
> instead.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>

Acked-by: Yonghong Song <yhs@...com>

> ---
> v2: simplified code as suggested by Daniel Borkmann
>
>  tools/lib/bpf/xsk.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)