netdev - Re: [PATCH net v2 0/2] Fix thunderx MTU with XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190410.193545.867822076372319682.davem@davemloft.net>
Date:   Wed, 10 Apr 2019 19:35:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mcroce@...hat.com
Cc:     netdev@...r.kernel.org, sgoutham@...ium.com, rric@...nel.org,
        linux-arm-kernel@...ts.infradead.org, ilias.apalodimas@...aro.org,
        brouer@...hat.com
Subject: Re: [PATCH net v2 0/2] Fix thunderx MTU with XDP

From: David Miller <davem@...emloft.net>
Date: Wed, 10 Apr 2019 19:35:16 -0700 (PDT)

> From: Matteo Croce <mcroce@...hat.com>
> Date: Mon,  8 Apr 2019 23:06:45 +0200
> 
>> The thunderx driver can't use XDP with all MTU values.
>> This patches sets the right MTU values, and add a check to avoid setting
>> a wrong value which will not function.
> 
> Series applied and queued up for -stable.

Actually, reverted, -ENOCOMPILE:

drivers/net/ethernet/cavium/thunder/nicvf_main.c: In function ‘nicvf_change_mtu’:
drivers/net/ethernet/cavium/thunder/nicvf_main.c:1596:15: error: ‘dev’ undeclared (first use in this function); did you mean ‘cdev’?
   netdev_warn(dev, "Jumbo frames not yet supported with XDP, current MTU %d.\n",
               ^~~
               cdev
drivers/net/ethernet/cavium/thunder/nicvf_main.c:1596:15: note: each undeclared identifier is reported only once for each function it appears in