netdev - Re: [PATCH net-next 01/12] net: hns3: fix VLAN initialization to be compatible with port base insert VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190411.112025.1323996172119715001.davem@davemloft.net>
Date:   Thu, 11 Apr 2019 11:20:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, shenjian15@...wei.com
Subject: Re: [PATCH net-next 01/12] net: hns3: fix VLAN initialization to
 be compatible with port base insert VLAN

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Thu, 11 Apr 2019 20:25:20 +0800

> From: Jian Shen <shenjian15@...wei.com>
> 
> This patch fixes VLAN initialization, in order to be compatible
> with VLAN inserted base on port.

This doesn't mean anything to me.

Why was normal VLAN initialization different, and how is the behavior
of VLAN's configured when inserted based upon port different and why
is it better?

You have to improve your commit log messages so that someone not
intimately familiar with your driver and code can understand what you
are doing and why.