netdev - Re: [net-next 1/1] tipc: use standard write_lock & unlock functions when creating node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190411.113621.1703861154991726814.davem@davemloft.net>
Date:   Thu, 11 Apr 2019 11:36:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: use standard write_lock & unlock
 functions when creating node

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 11 Apr 2019 20:27:08 +0200

> In the function tipc_node_create() we protect the peer capability field
> by using the node rw_lock. However, we access the lock directly instead
> of using the dedicated functions for this, as we do everywhere else in
> node.c. This cosmetic spot is fixed here.
> 
> Fixes: 40999f11ce67 tipc: make link capability update thread safe
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Hello Jon, please format Fixes: tags as follows:

Fixes: SHA_ID_12DIGITS ("Commit header line text")

Thank you.