netdev - Re: [PATCH v2 net-next] selftests: Add debugging options to pmtu.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190411210415.1ba9acf1@redhat.com>
Date:   Thu, 11 Apr 2019 21:04:15 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v2 net-next] selftests: Add debugging options to pmtu.sh

On Thu, 11 Apr 2019 11:51:50 -0700
David Ahern <dsahern@...nel.org> wrote:

> From: David Ahern <dsahern@...il.com>
> 
> pmtu.sh script runs a number of tests and dumps a summary of pass/fail.
> If a test fails, it is near impossible to debug why. For example:
> 
>     TEST: ipv6: PMTU exceptions                       [FAIL]
> 
> There are a lot of commands run behind the scenes for this test. Which
> one is failing?
> 
> Add a VERBOSE option to show commands that are run and any output from
> those commands. Add a PAUSE_ON_FAIL option to halt the script if a test
> fails allowing users to poke around with the setup in the failed state.
> 
> In the process, rename tracing to TRACING and move declaration to top
> with the new variables.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
> v2
> - moved tracing to TRACING, dropped eval and quoted command in new run_cmd,
>   dropped local from declarations - all comments from Stefano

Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano