netdev - Re: [PATCH bpf-next] bpf: fix missing bpf_check_uarg_tail_zero in BPF_PROG_TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ae7a9ae-1d07-afaf-c31f-1c46f48df9f2@iogearbox.net>
Date:   Thu, 11 Apr 2019 21:52:55 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH bpf-next] bpf: fix missing bpf_check_uarg_tail_zero in
 BPF_PROG_TEST_RUN

On 04/11/2019 06:12 PM, Stanislav Fomichev wrote:
> Commit b0b9395d865e ("bpf: support input __sk_buff context in
> BPF_PROG_TEST_RUN") started using bpf_check_uarg_tail_zero in
> BPF_PROG_TEST_RUN. However, bpf_check_uarg_tail_zero is not defined
> for !CONFIG_BPF_SYSCALL:
> 
> net/bpf/test_run.c: In function ‘bpf_ctx_init’:
> net/bpf/test_run.c:142:9: error: implicit declaration of function ‘bpf_check_uarg_tail_zero’ [-Werror=implicit-function-declaration]
>    err = bpf_check_uarg_tail_zero(data_in, max_size, size);
>          ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Let's not build net/bpf/test_run.c when CONFIG_BPF_SYSCALL is not set.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Fixes: b0b9395d865e ("bpf: support input __sk_buff context in BPF_PROG_TEST_RUN")
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Makes sense, applied, thanks!